Better dev experience for JS generated file hashes #7975
Conversation
jprochazk
added
🧑💻 dev experience
Deployed docs
|
| @@ -12,7 +12,8 @@ | |||
| ], | |||
| "scripts": { | |||
| "build:types": "tsc --noEmit && dts-buddy", | |||
| "build": "npm run build:types" | |||
| "build": "npm run build:types", | |||
| "build:no-check": "npm run build" | |||
There was a problem hiding this comment.
This does the same thing as build, it's only here for compatibility with running the same command across all packages in the yarn workspace (yarn --cwd rerun_js workspaces run build:no-check would fail on the web-viewer-react package otherwise)
There was a problem hiding this comment.
That's a great comment - it should be comited :)
There was a problem hiding this comment.
yes, it would be nice if it was possible to put comments in JSON. i'm not sure where else to put it
| "js-install", | ||
| ] } | ||
|
|
||
| js-update-hashes = { cmd = "node rerun_js/web-viewer/build-wasm.mjs --update-hashes", depends_on = [ |
There was a problem hiding this comment.
docstring! Update what hashes? Why and when would they need updating?
| @@ -12,7 +12,8 @@ | |||
| ], | |||
| "scripts": { | |||
| "build:types": "tsc --noEmit && dts-buddy", | |||
| "build": "npm run build:types" | |||
| "build": "npm run build:types", | |||
| "build:no-check": "npm run build" | |||
There was a problem hiding this comment.
That's a great comment - it should be comited :)
|
Honestly, I think my solution to this problem ( |
What
pixi run js-build-*, more generally appending:no-checkto the npmbuildcommands will do the same)pixi run js-update-hashes.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.