Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error & download url if ffmpeg is missing #7991

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 4, 2024

What

image

Future work:

  • download for you in the viewer to a location we manage
  • have location be an application setting

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Nov 4, 2024
@Wumpf Wumpf merged commit d61018c into main Nov 5, 2024
36 checks passed
@Wumpf Wumpf deleted the andreas/ffmpeg-install-help branch November 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants