Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version strings with commit hashes #8041

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 7, 2024

What

We want to include the commit hash in the version string when we publish wheel builds off of main (i.e. not actual releases), so that we get unique version strings.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) ⛴ release Related to shipping or publishing exclude from changelog PRs with this won't show up in CHANGELOG.md dataplatform Rerun Data Platform integration labels Nov 7, 2024
@emilk emilk marked this pull request as ready for review November 7, 2024 16:59
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@emilk emilk merged commit a834b77 into main Nov 7, 2024
36 checks passed
@emilk emilk deleted the emilk/commit-hashes-in-versions branch November 7, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants