Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC spec update: Add support for selecting specific columns while listing recordings metadata #8049

Merged
merged 7 commits into from
Nov 11, 2024
Merged

gRPC spec update: Add support for selecting specific columns while listing recordings metadata #8049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0284f44
gRPC spec update: add metadata update API call
zehiko Nov 7, 2024
3890f63
spelling fix
zehiko Nov 7, 2024
bf0742b
list recordings supports projecting specific columns
zehiko Nov 8, 2024
b35bff4
make selection optional
zehiko Nov 8, 2024
dfd05ac
fix build
zehiko Nov 8, 2024
e3cc57d
rename column projection
zehiko Nov 8, 2024
bee434e
Merge branch 'main' into zehiko/list-recordings-projection
zehiko Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/store/re_protos/proto/rerun/v0/remote_store.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,16 @@ enum EncoderVersion {

// ----------------- ListRecordings -----------------

message ListRecordingsRequest {}
message ListRecordingsRequest {
// define which columns should be returned / projected
// we define a separate message to make it optional.
// If not provided, all columns should be returned
ColumnProjection column_projection = 1;
}

message ColumnProjection {
repeated string columns = 1;
}

message ListRecordingsResponse {
repeated RecordingMetadata recordings = 1;
Expand Down
15 changes: 13 additions & 2 deletions crates/store/re_protos/src/v0/rerun.remote_store.v0.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion rerun_py/src/remote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ impl PyConnection {
/// List all recordings registered with the node.
fn list_recordings(&mut self) -> PyResult<Vec<PyRecordingMetadata>> {
self.runtime.block_on(async {
let request = ListRecordingsRequest {};
let request = ListRecordingsRequest {
column_projection: None,
};

let resp = self
.client
Expand Down
Loading