Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure videos all end up in different space views #8085

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 12, 2024

What

My previous "fix" in #7869 only solved the problems for videos with different dimensions. This solves the problem for all videos.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested but code lgtm

@emilk emilk merged commit 7b3135a into main Nov 12, 2024
42 checks passed
@emilk emilk deleted the emilk/fix-video-stacking-again branch November 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heuristic stacks video frames rather than giving them their own 2d views
2 participants