Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never direct users towards using RecordingStream::log_component_batches #8149

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 14, 2024

RecordingStream::log_component_batches is a clunky implementation detail, at best. Users should be directed towards RecordingStream::log{_static}, always.

To do so, we implement AsComponents for basic collections of dyn ComponentBatches, and update all examples accordingly.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

To deploy documentation changes immediately after merging this PR, add the deploy docs label.

@teh-cmc teh-cmc added enhancement New feature or request 🦀 Rust API Rust logging API 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Nov 14, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 14, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11841056646

@teh-cmc teh-cmc merged commit 9e46657 into main Nov 15, 2024
80 checks passed
@teh-cmc teh-cmc deleted the cmc/as_components_everywhre branch November 15, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) enhancement New feature or request include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants