Introduce APIs for list_recordings and update_metadata #8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
jleibs
added
🐍 Python API
jleibs
force-pushed
the
jleibs/remote_apis
branch
from
7ab5f43 to
711a372
Compare
jleibs
commented
Nov 26, 2024
zehiko
approved these changes
Nov 26, 2024
| .map(|tc| tc.try_to_arrow_record_batch()) | ||
| .collect(); | ||
|
|
||
| // TODO(jleibs): surfacing this schema is awkward. This should be more explicit in |
There was a problem hiding this comment.
should we expose schema as top level field for get/list metadata, even though it's in the transport chunk?
I guess for the Query (i.e. data API) we should (as initially discussed) strive to go the opposite way and only include the schema in the first message of the stream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What