Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC spec update: make metadata APIs more like the data API #8292

Merged
merged 9 commits into from
Dec 6, 2024

Conversation

zehiko
Copy link
Contributor

@zehiko zehiko commented Dec 3, 2024

What

As part of simplifying metadata APIs and as pre-req for creating gRPC catalog data source, we:

  • expose only single API for querying metadata (that supports filtering and projection)
  • this API now returns a stream of chunks, same as the data API

Testing done

  • integrated changes into SN

@zehiko zehiko requested a review from jleibs December 3, 2024 11:53
@zehiko zehiko self-assigned this Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
077f041 https://rerun.io/viewer/pr/8292

Note: This comment is updated whenever you push a commit.

@zehiko zehiko added exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API labels Dec 3, 2024
@zehiko zehiko marked this pull request as draft December 3, 2024 11:58
@zehiko zehiko marked this pull request as ready for review December 3, 2024 13:58
Copy link

github-actions bot commented Dec 5, 2024

Latest documentation preview deployed successfully.

Result Commit Link
5248fdd https://landing-7yuuqmu9y-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@zehiko zehiko merged commit 0bd35e6 into main Dec 6, 2024
32 checks passed
@zehiko zehiko deleted the zehiko/grpc-metadata-update branch December 6, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants