Visually differentiate implicit nodes in graph view #8313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtlr
added
🪳 bug
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
approved these changes
Dec 4, 2024
grtlr
added a commit
that referenced
this pull request
Dec 4, 2024
### What After refactoring, _implicit_ nodes were visualized using regular `text_color` and where therefore no possible to differentiate from regular nodes. This PR fixes that. <img width="44" alt="image" src="https://github.com/user-attachments/assets/d1c32758-2154-4842-ab18-9be9b899c6d0"> The node on the bottom (darker gray) is implicit. <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
After refactoring, implicit nodes were visualized using regular
text_colorand where therefore no possible to differentiate from regular nodes. This PR fixes that.The node on the bottom (darker gray) is implicit.