Fix outlines for lines having more preceived aliasing since 0.20 #8317
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
Wumpf
commented
Dec 4, 2024
| @@ -2182,7 +2182,7 @@ fn quote_archetype_field_type(hpp_includes: &mut Includes, obj_field: &ObjectFie | |||
| quote! { Collection<#elem_type> } | |||
| } | |||
| // TODO(andreas): This should emit `MonoCollection` which will be a constrained version of `Collection`. | |||
| // (simply adapting `MonoCollection` breaks some existing code, so this not entirely trivial to do. | |||
| // (Simply adapting `MonoCollection` breaks some existing code, so this not entirely trivial to do. | |||
There was a problem hiding this comment.
load bearing rust change so I get web builder ci triggered
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
All screenshots on MacOS lowdpi (==scaling 100%) since it's easier to spot there (but also still impactful on highdpi==scaling>=200%). Listing WebGPU & WebGL separately since WebGL version doesn't do anti-aliasing on outlines (technical limitations)
0.19 WebGPU Chrome
0.20/main WebGPU Chrome
This PR WebGPU Chrome
0.19 WebGL Chrome
0.20/main WebGL Chrome
This PR WebGL Chrome
