-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail codegen when archetype fields don't have one of the required attributes #8326
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.. hower, I didn't realize you put this into the rust codegen when this is actually completely language agnostic.
this should go into Objects::from_raw_schema
which is where we have general validation like this
... but I don't want to hold up if this turns out to be too much hassle.
thanks! |
What
All of our archetypes' fields must have one of the
attr.rerun.component_{required|recommended|optional}
attribute. Let's fail codegen when they are missing, so we stop falling into that pitfall.