-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the near clipping plane editable in 2D views #8348
Conversation
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
We get flickering when zooming in on some scenes. Objectron showed that quite well back then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Also unsure about the visual bounds aspect 🤔. But that's the lowest friction place right now, we can always move it around again 🤷
/// Controls the distance to the near clipping plane | ||
clipping_plane: rerun.blueprint.components.ClippingPlane ("attr.rerun.component_optional", order: 2000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to call the field near_clip_plane
- near
for descriptiveness, clip
for brevity (and the type then ClipPlane
)
(?)
What
This adjusts the value to now be in physical scene units. I.e. for most 3d scenes in meters, the clip plane will be 10cm, which is a very reasonable default.
Additionally, this gives users an escape hatch for scenes where the default clipping plane causes their data to not be visible.
Test script:
New issues: