Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement complete Graph View example #8421

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Implement complete Graph View example #8421

merged 13 commits into from
Dec 12, 2024

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Dec 11, 2024

What

This PR tries to create a more convincing example for the graph view.

It consists of 4 views:

  • A tree that randomly grows over time
  • A bubble chart with new bubbles coming in over time
  • The lattice, which is logged statically but without positions
  • And finally a Markov-Chain with fixed positions

There are still some minor things to fix:

  • That one weird edge in the Markov-Chain
  • It would be nice if the viewer would fit the resulting graphs to the view.
image

Copy link

github-actions bot commented Dec 11, 2024

Latest documentation preview deployed successfully.

Result Commit Link
fa5809c https://landing-ma10vfwy0-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Dec 11, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
fa5809c https://rerun.io/viewer/pr/8421 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr added ui concerns graphical user interface examples Issues relating to the Rerun examples include in changelog labels Dec 11, 2024
@grtlr grtlr force-pushed the grtlr/better-example branch from e328ff1 to bd71bf0 Compare December 11, 2024 16:24
@grtlr grtlr marked this pull request as ready for review December 12, 2024 08:02
@teh-cmc teh-cmc self-requested a review December 12, 2024 08:40
@teh-cmc teh-cmc force-pushed the grtlr/better-example branch from 15e18a3 to c267ccc Compare December 12, 2024 08:44
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works great.

Gotta figure out which examples stay and which ones go, and update the manifest accordingly.
If a Rust example stay, then please keep the Python counterpart too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always suspicious when a check gets removed 😬. What's the reasoning here? (Reminder: people don't regularly go through all the examples; they do go through the entire checklist though).

Copy link
Contributor Author

@grtlr grtlr Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one check used to be a special case for the graph view back when we didn't have the physics simulation fully set up.

Now that we have this that check it evolved into the full-featured example. The remaining graph check covers the more weird edge cases.

examples/python/graphs/graphs.py Outdated Show resolved Hide resolved
@grtlr grtlr merged commit 776aa4f into main Dec 12, 2024
36 of 37 checks passed
@grtlr grtlr deleted the grtlr/better-example branch December 12, 2024 11:58
@teh-cmc teh-cmc changed the title Create a more convincing example of the graph view Implement complete Graph View example Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants