Fix deadlock when flushing messages #843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way things were set up dropping Arrow messages was grabbing the GIL which would deadlock since the shutdown function was already holding the GIL before flushing. Fix this by (1) dropping messages in their own thread so we never block the tcp_sender and (2) releasing the GIL during shutdown since we aren't interacting with any python objects anyways.
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)