Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single-click and double-click in the graph view #8474

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Dec 16, 2024

Related

What

This implements:

  • Single-click on empty space to select view.
  • Double-click on node to select entire entity.

Merging @emilk's recent changes (#8469 and #8457) seems to have fixed the flickering on selection too.

Copy link

github-actions bot commented Dec 16, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
37d19d9 https://rerun.io/viewer/pr/8474 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Dec 16, 2024
@grtlr grtlr force-pushed the grtlr/8437-double-click branch from 141c3d3 to f8e6d80 Compare December 16, 2024 11:20
@grtlr grtlr marked this pull request as ready for review December 16, 2024 11:21
@grtlr grtlr changed the title Fix selections and double-click in the graph view Fix single-click and double-click in the graph view Dec 16, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Dec 16, 2024

If clicking the background selects the view, then hovering the background should highlight it

@teh-cmc teh-cmc merged commit 40338bd into main Dec 16, 2024
34 checks passed
@teh-cmc teh-cmc deleted the grtlr/8437-double-click branch December 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
2 participants