Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve graphics device capability detection, warn on old devices, early error on unsupported render targets #8476

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 16, 2024

Related

What

Improved & sharpend overall how we handle device tiers. Next steps that went too far in scope right now detailed in

Testing

this shouldn't be all that problematic, but just in case let's be thorough:

  • WebGL
  • WebGPU
  • Mac Metal
  • Windows Vulkan
  • Windows OpenGL
  • Linux Vulkan
  • Linux OpengL

@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself include in changelog labels Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
1589ae6 https://rerun.io/viewer/pr/8476 +nightly +main

Note: This comment is updated whenever you push a commit.

crates/viewer/re_renderer/src/config.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 4f9ba38 into main Dec 17, 2024
30 of 32 checks passed
@Wumpf Wumpf deleted the andreas/warn-for-missing-driver-features branch December 17, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewer should warn & not start when Rgba32Float is not renderable
2 participants