Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide graph edges from individual graph node ui #8511

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 17, 2024

Related

What

Lots of considerations & (soft) implications in this hack, see comment.

The important outcome here is that node hover now looks like this:
image
node selection:
image
and node entity selection (note that edges are still around:
image
also you can still browse the edges:
image

@Wumpf Wumpf added ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
062b847 https://rerun.io/viewer/pr/8511 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf requested a review from grtlr December 17, 2024 16:54
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤩

@Wumpf Wumpf merged commit e9b2bff into main Dec 18, 2024
31 checks passed
@Wumpf Wumpf deleted the andreas/hide-graph-edges branch December 18, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants