-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter entities in the UI (part 0): Make CustomContent
more useful
#8645
Conversation
…ct`, and has support for action button
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
CustomContent
more usefulCustomContent
more useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
makes me so happy that this is right away handled by a screenshot test
} | ||
|
||
impl ListItemContent for CustomContent<'_> { | ||
fn ui(self: Box<Self>, ui: &mut egui::Ui, context: &ContentContext<'_>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a bit of a deja vu - isn't this button handling code already somewhere else? (can't tell without digging if that's actually the case and whether that's even a concern)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I already have some kind of abstraction for button thingies (could be menu, could be action). Look for the ItemButton
trait. I'm using that in PropertyContent
, so I'm piggy backing on it.
Related
CustomContent
more useful #8645re_blueprint_tree
and add more tests #8795re_time_panel
and add more tests #8863What
This PR makes
CustomContent
for list items more useful, because I'll needed for the UI of the filter widget. I also cleans up a few things and updates the related snapshot test.