-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @uncurry decorator syntax lookup #179
Add @uncurry decorator syntax lookup #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small rephrasing required.
Small note: A paragraph should always be in one line, so it's easier to diff on them (use line-wrapping for editing)
@@ -0,0 +1,36 @@ | |||
--- | |||
id: "uncurry-decorator" | |||
keywords: ["uncurry", "decorator"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before i forget, one of the keywords should probably also be @bs.uncurry
, due to the fact that we will have a lot of users on old versions of ReScript / older blog posts that still use the @bs.
prefix convention.
Not a blocker, just wanted to mention
Suggestion for the
@uncurry
decorator syntax page for #162I've experimented with this one a little, but I haven't yet found it to make any difference. I.e. using the decorator or omitting the decorator had no obvious effect on how the callback is called, or the resulting generated JS code.
I'm guessing the code I've tried so far has not been complex enough to trigger the benefits this decorator brings? Just thought I would mention it.
As usual, happy to receive any feedback on this PR.