Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting for types #89

Closed
TheSpyder opened this issue Mar 5, 2021 · 0 comments · Fixed by #367
Closed

Syntax highlighting for types #89

TheSpyder opened this issue Mar 5, 2021 · 0 comments · Fixed by #367

Comments

@TheSpyder
Copy link

Types don't seem to have a colour in the highlighting. I've tried every recommended colour theme and they all have the same problem. This screenshot uses Dark+.

Screen Shot 2021-03-05 at 11 16 47 am

I would prefer types such as string, option, bool and the t from Js.Null.t to be given a colour. The lack of any highlighting in option<bool> seems particularly weird. It would also be nice if the type definition (attributeSelector) had a colour.

I'm using v1.0.6 with vscode freshly updated to 1.54.1.
chenglou added a commit that referenced this issue Mar 31, 2021
@chenglou
Highlight type param
8113017 
This is one of the few remaining unambiguous things in our syntax (uuugh), so let's at least highlight this first.

Fixes part of #89
chenglou added a commit that referenced this issue Apr 23, 2021
@chenglou
Make the unmonad script turn the let% into switch instead (#89)
61f7e7b 
* Make the unmonad script turn the let% into `switch` instead

Follow-up of #87

Now we can properly add error handling to these `None`/`Error(_)` later

* Check in the tests on 2 files

Supercedes #86
chenglou added a commit that referenced this issue Apr 24, 2021
@chenglou
Make the unmonad script turn the let% into switch instead (#89)
7dff7b6 
* Make the unmonad script turn the let% into `switch` instead

Follow-up of #87

Now we can properly add error handling to these `None`/`Error(_)` later

* Check in the tests on 2 files

Supercedes #86
@chenglou chenglou reopened this Apr 27, 2021
@TheSpyder TheSpyder mentioned this issue May 26, 2021
Closed
@zth zth mentioned this issue Mar 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Semantic syntax highlighting zth/rescript-vscode
2 participants
@TheSpyder @chenglou