Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rescript-tools: do not override flags for static linking #1013

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jun 8, 2024

Fixes #1006.

@woeps
Copy link
Contributor

woeps commented Jun 8, 2024

I ran DUNE_PROFILE=static opam exec -- make locally on my linux machine and calling file ./_build/default/tools/bin/main.exe now gives:

main.exe: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statically linked, BuildID[sha1]=605ca79a225725810f29e03d1df972cb0abaa4d8, for GNU/Linux 4.4.0, with debug_info, not stripped

I assume running the same command in ci (using alpine image) should have similar results.

Thanks for your efforts!

@cknitt cknitt merged commit 6c458c4 into rescript-lang:master Jun 8, 2024
6 checks passed
@cknitt cknitt deleted the fix-tools-static branch June 8, 2024 15:09
@zth
Copy link
Collaborator

zth commented Jun 8, 2024

@woeps releasing this in 0.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools linux binary dynamically links musl
3 participants