null check reanalyze output #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Jun 15, 2022
| try { | ||
| var json = JSON.parse(data); | ||
| json = JSON.parse(data); | ||
| } catch (e) { | ||
| window.showErrorMessage( | ||
| `Something went wrong parsing the json output of reanalyze: '${e}'` |
There was a problem hiding this comment.
Can you add a bit more. How about encouraging reporting the issue.
There was a problem hiding this comment.
I'll add this in a separate PR when I've figured out what makes sense to tell the user here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't accidentally crash the extension if we don't get proper json from reanalyze. It happens locally for me, which is another issue I'll investigate. But, this will at least ensure we don't crash.