Clickable links in hovers #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Sep 13, 2022
| @@ -2,6 +2,36 @@ open SharedTypes | |||
|
|
|||
| let codeBlock code = Printf.sprintf "```rescript\n%s\n```" code | |||
|
|
|||
| let encodeURIComponent text = | |||
There was a problem hiding this comment.
This needs to be replaced by something vastly more complete/robust. Hopefully there's something for OCaml we can find and vendor or similar.
zth
commented
Sep 13, 2022
…s that cannot handle markdown links
cristianoc
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. cc @cristianoc
TODO before merge:
encodeURIComponentfunction with something robust/complete