custom LSP requests #611
Merged
custom LSP requests #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice! I'll review soon. |
|
Did you test all of this in VSCode again after making the changes? |
|
Yes |
zth
approved these changes
Nov 13, 2022
|
@aspeddro would you resolve the merge conflict? Then we're ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing some handlers in Neovim for
createInterfaceandopenCompiled. Methods names use the same format to register commands in vscode e.grescript-vscode.open_compiledRename methods names, following LSP spec:
rescript-vscode.open_compiled=>textDocument/openCompiledrescript-vscode.create_interface=>textDocument/createInterfaceResponse changes:
textDocument/openCompilednow return uri file schemetextDocument/createInterfacenow return the path of the file, so that I can open the file after creation