fix: document symbol path location #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Nov 11, 2022
cristianoc
added a commit
that referenced
this pull request
Dec 16, 2022
The change in #629 moved to a non-deprecated representation of document symbol. The new representation is the "Ikea" version of the old one, where children symbol are not computed for you, but need to be provided. This PR computes and emits the tree of symbols using the `children` field.
cristianoc
added a commit
that referenced
this pull request
Dec 16, 2022
Fixes #654. The change in #629 moved to a non-deprecated representation of document symbol. The new representation is the "Ikea" version of the old one, where children symbol are not computed for you, but need to be provided. This PR computes and emits the tree of symbols using the `children` field.
cristianoc
added a commit
that referenced
this pull request
Dec 17, 2022
* Emit nested document symbols. Fixes #654. The change in #629 moved to a non-deprecated representation of document symbol. The new representation is the "Ikea" version of the old one, where children symbol are not computed for you, but need to be provided. This PR computes and emits the tree of symbols using the `children` field. * indent * Refactor code for indentation. * Update CHANGELOG.md * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change response format to documentSymbol. symbolInformation are deprecated.
Close #628