Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo pr 649 #651

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Redo pr 649 #651

merged 5 commits into from
Dec 13, 2022

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc mentioned this pull request Dec 13, 2022
Closed
@cristianoc
Copy link
Collaborator Author

@aspeddro this should work, only needs cleaning up the changelog.

@aspeddro
Copy link
Contributor

I thought it was fixed in master. Thanks @cristianoc.

@cristianoc
Copy link
Collaborator Author

These are 2 different issues:
1 references to elements defined in interface files
2 references from implementation files which also happen to have interface files

@cristianoc
Copy link
Collaborator Author

1 in master
2 here

@cristianoc cristianoc merged commit dd056e2 into master Dec 13, 2022
@cristianoc cristianoc deleted the redo_pr_649 branch December 13, 2022 18:32
@cristianoc
Copy link
Collaborator Author

All done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianoc @aspeddro