Complete function argument values #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Dec 25, 2022
| @@ -1455,6 +1455,131 @@ let getOpens ~debug ~rawOpens ~package ~env = | |||
| (* Last open takes priority *) | |||
| List.rev resolvedOpens | |||
|
|
|||
| let getArgs ~env (t : Types.type_expr) ~full = | |||
There was a problem hiding this comment.
This one is mostly copied from a pre-existing fn, but with identifying what type of argument is found (labelled or unlabelled).
zth
commented
Dec 25, 2022
analysis/src/CompletionBackEnd.ml
Outdated
Comment on lines
1539
to
1540
| ~name: | ||
| (constructor.cname.txt |
There was a problem hiding this comment.
Bonus points @cristianoc - can we somehow figure out if we need to qualify the constructor here? Not something we need to do now, but something worth thinking about for the future.
zth
commented
Dec 25, 2022
analysis/src/CompletionBackEnd.ml
Outdated
Comment on lines
1559
to
1564
| Completion.create ~name:"None" | ||
| ~kind:(Label (t |> Shared.typeToString)) | ||
| ~env; | ||
| Completion.create ~name:"Some(_)" | ||
| ~kind:(Label (t |> Shared.typeToString)) | ||
| ~env; |
There was a problem hiding this comment.
I'm going to improve this a lot soon. Mainly 2 things:
Some(_)will eventually be a snippetSome($1:_), which means that the cursor is automatically positioned in the option payload (so we can keep completing the option value)- If the inner type is "small" enough (bool, variant with few payloads, etc), we can expand those into the list directly, so that instead of
None/Some(_), it'd beNone/Some(true)/Some(false)for bools, etc.
cristianoc
approved these changes
Dec 26, 2022
…structor argument
… is a prefix to filter on
zth
force-pushed
the
complete-named-arguments
branch
from
f866efb
to
5995f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first in likely a long series of PRs bringing in and refining the work done in #493, but little bit by bit.
This PR does the following:
There are caveats that I've added comments for in the PR.
The next step will be getting support for snippets in completion items in, so we can intelligently move the cursor for the user into payloads of constructors etc. That'll come in a separate PR.
After that, completing polyvariants.
Then the same work as in this PR, but for JSX props.