More completion for unsaved code. #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
reviewed
Jan 26, 2023
cristianoc
reviewed
Jan 26, 2023
zth
force-pushed
the
ctx-path-backup
branch
2 times, most recently
from
2ea2379
to
f24b5b2
Compare
start having a single entry point for completions
|
Need to rebase on master. |
cristianoc
force-pushed
the
ctx-path-backup
branch
from
04c8a6e
to
3c9193f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for a first round of feedback @cristianoc. I've commented on a few things I haven't figured out yet. So looking for feedback on that, plus on the general approach.
A surprising amount of quite juicy use cases already work though, which is exciting. You'll see in the tests.