treat signature help as a stable feature #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Feb 5, 2023
| @@ -158,10 +158,10 @@ | |||
| "default": false, | |||
| "description": "Enable (experimental) code lens for function definitions." | |||
| }, | |||
| "rescript.settings.signatureHelp.enable": { | |||
| "rescript.settings.signatureHelp.enabled": { | |||
There was a problem hiding this comment.
Changing the name of this setting so it resets for all users, and defaults to true.
cristianoc
approved these changes
Feb 6, 2023
zth
force-pushed
the
stable-signature-help
branch
from
c9ecfa7 to
ac5bf99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes signature help to be a stable feature, turned on by default.