Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add completion toplevel decorators #799

Merged
merged 6 commits into from
Aug 13, 2023

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Aug 5, 2023

image

@@ -30,8 +30,6 @@ It is also possible to map a ReScript record to a JavaScript array by passing in
[
{|The `@deprecated` decorator is used to add deprecation notes to types, values and submodules. The compiler and editor tooling will yield a warning whenever a deprecated entity is being used.

Alternatively, use the `@@deprecated` decorator to add a deprecation warning to the file level.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this really be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here e3e0463

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍 Just one small comment.

@zth zth merged commit 3110b2e into rescript-lang:master Aug 13, 2023
5 checks passed
@aspeddro aspeddro deleted the fix-completion-attr branch October 12, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants