revamp insert missing cases code action #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduce the missing cases and insert them into the existing switch
cristianoc
approved these changes
Aug 16, 2023
| @@ -392,6 +392,14 @@ let test ~path = | |||
| Printf.printf "%s\nnewText:\n%s<--here\n%s%s\n" | |||
| (Protocol.stringifyRange range) | |||
| indent indent newText))) | |||
| | "c-a" -> | |||
There was a problem hiding this comment.
Unambiguous but getting a bit cryptic
There was a problem hiding this comment.
It's "codemod - AddMissingCases" 😅 Might be make more sense to have the codemod variant derived from the rest of the string too...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revamps the current "Insert missing cases" code action by leveraging actual AST transforms to produce the updated switch code instead of relying on unstable and ad hoc string parsing. This is now possible thanks to the compiler printing the cases in ReScript syntax rather than OCaml syntax.
Example:
