-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@rescript/tools
package
#829
Conversation
Looking great overall! I think we can rely on the v11 variant representation here for the JSON format, and just require people to use v11. Seems like it'd clean things up a bit. |
Ready for review |
@tag("kind") | ||
type detail = | ||
| @as("record") Record(array<field>) | ||
| @as("variant") Variant(array<constructor>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right. Did you test this somehow? Anyway we can fix in a follow up perhaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thank you very much! I have a couple of adjustments I'd like to make but I can make them in a separate PR.
A binary called
restools
with two subcommands. One for document generation and another for renalyze, see README.mdThe package also exposes the
Docgen
module to decode from JSONYou can publish with the commit message
publish tools
by pushing to master.