Complete lowercase JSX labels from the domProps type #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
force-pushed
the
complete-lowercase-jsx-labels-from-domprops
branch
from
ed89d5e
to
7220e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change completion of DOM props of lowercase elements to try to look up
ReactDOM.domPropsfirst, before falling back to the current method of completing from a pre-defined list of DOM props (that was there because of JSXv3).This is an adaption to JSXv4, and also a preparation for our upcoming generic JSX transform where we'll want to be able to swap out
domPropsto something custom for the generic transform.