Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambigious case with JSX brace wraps and record body #894

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Jan 11, 2024

Fix ambigious case where JSX brace wraps in JSX props are interpreted as a record body, but we dont know whether it actually is a record body or just wraps for the prop value itselfix ambigious case where JSX brace wraps in JSX props are interpreted as a record body, but we dont know whether it actually is a record body or just wraps for the prop value itself.

… as a record body, but we dont know whether it actually is a record body or just wraps for the prop value itself
@zth zth requested a review from cristianoc January 11, 2024 09:23
@zth
Copy link
Collaborator Author

zth commented Jan 11, 2024

Side note: Life is so much easier with proper debug statements. Will continue adding these as I fix things.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description in the change log should say that in case of ambiguity, both completions are provided.

@zth zth merged commit baf1d47 into master Jan 11, 2024
3 checks passed
@zth zth deleted the fix-jsx-prop-ambigious-record-body-completion branch January 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants