Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion for import attributes in @module #913

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Feb 7, 2024

Adds completion for the new import attributes in @module.

@zth zth requested a review from cristianoc February 7, 2024 09:31
@cristianoc
Copy link
Collaborator

looks like CI is red
leftover of the previous CI issues which were not fully solved?

@zth zth force-pushed the completion-for-import-attributes branch from a9c2be7 to 4bd983d Compare February 7, 2024 10:07
@zth
Copy link
Collaborator Author

zth commented Feb 7, 2024

@cristianoc look again

@zth zth merged commit bb44aa7 into master Feb 7, 2024
5 checks passed
@zth zth deleted the completion-for-import-attributes branch February 7, 2024 10:35
aspeddro pushed a commit to aspeddro/rescript-vscode that referenced this pull request Mar 4, 2024
* add completion for import attributes in @module

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants