Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance module attribute completion some more #918

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Feb 7, 2024

  • Relax filter for what local files that come up in from and regular string completion in @module
  • Make from completion trigger for expr hole so we get a nice experience when completing {from: <com>}.

@zth zth requested a review from cristianoc February 7, 2024 19:41
@cristianoc
Copy link
Collaborator

Any idea what's up with CI? It seems to report on .js and .ml files, which is strange.

@zth zth merged commit 80fde16 into master Feb 10, 2024
5 checks passed
@zth zth deleted the enhance-module-attribute-completion-2 branch February 10, 2024 20:30
aspeddro pushed a commit to aspeddro/rescript-vscode that referenced this pull request Mar 4, 2024
* enhance module attribute completion some more

* changelog

* sort file results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants