Generic JSX transform completion #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Feb 8, 2024
.gitignore
Outdated
| @@ -7,6 +7,10 @@ analysis/tests/lib | |||
| analysis/tests/.bsb.lock | |||
| analysis/tests/.merlin | |||
|
|
|||
| analysis/tests-generic-jsx-transform/lib | |||
| analysis/tests-generic-jsx-transform/.bsb.lock | |||
| analysis/tests-generic-jsx-transform/.merlin | |||
There was a problem hiding this comment.
I think .merlin files are not generated anymore.
zth
force-pushed
the
generic-jsx-transform-completion
branch
from
99d6b61
to
580ac3c
Compare
zth
force-pushed
the
generic-jsx-transform-completion
branch
from
be35114
to
8f7346f
Compare
aspeddro
pushed a commit
to aspeddro/rescript-vscode
that referenced
this pull request
Mar 4, 2024
* add test project for generic JSX transform * adapt completion to look up the correct types when using a generic JSX transform * changelog * adapt the primitive completions inside of jsx to the generic JSX moe * remove uneccessary ignore * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the JSX lowercase element completion (both for the attribute names and values) to look up the proper type if using a generic JSX transform, instead of relying on hard coded paths to React and ReactDOM.
I set up a new test project for this because that felt the least invasive compared to changing the main test project's JSX config.
Closes #914