Heuristic for JSX empty prop expr completion #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
reviewed
Mar 1, 2024
| } | ||
| } | ||
|
|
||
| // <MultiPropComp name="Hello" time= age="35" |
There was a problem hiding this comment.
can you add examples with prop punning, and where there is more than one prop assignment already?
There was a problem hiding this comment.
Done, check the latest commit.
zth
force-pushed
the
fix-empty-jsx-prop-completion
branch
from
024b994
to
0354606
Compare
aspeddro
pushed a commit
to aspeddro/rescript-vscode
that referenced
this pull request
Mar 4, 2024
* apply heuristic for allowing empty JSX prop expr completion * changelog * add examples with punning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that made empty prop expressions in JSX not complete if in the middle of a JSX element, because of the parser not being able to provide an expr hole for the empty prop expr (which in turn is because of valid reasons).