Signature help fixes #950
Merged
Signature help fixes #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zth
commented
Mar 10, 2024
zth
commented
- Ensures that locations are taken into account, so that the deepest signature help item with the cursor is the one that triggers.
- Refactors the function call lookup so that we try using typed information first before resorting to using the completion enginge for unsaved content. This will yield better results with incremental type checking because type params etc will be instantiated.
…em is always the one getting focus
…for function calls. This will give better results since typed info will have type variables instantiated
cristianoc
approved these changes
Mar 10, 2024
Should not be, no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.