Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable signature help for option and result #955

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Enable signature help for option and result #955

merged 1 commit into from
Mar 13, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Mar 13, 2024

Doesn't need a changelog.

@zth zth requested a review from cristianoc March 13, 2024 13:58
cristianoc
cristianoc approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only on these 3 variant cases?
Do they have something special in common?

@zth
Copy link
Collaborator Author

zth commented Mar 13, 2024

Why only on these 3 variant cases? Do they have something special in common?

Since option and result are now builtins, they're not covered by the generic variant stuff (which is what was used before). So they need to be handled separately like this.

@zth zth merged commit bb4e36d into master Mar 13, 2024
5 checks passed
@zth zth deleted the signature-help-option-result branch March 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc