Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expr record field completion in existing records #997

Merged
merged 4 commits into from
May 29, 2024
Merged

Fix expr record field completion in existing records #997

merged 4 commits into from
May 29, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented May 29, 2024

This fixes 2 cases that were broken when completing record fields in expressions:

  • Starting to write out a new field name was mistakenly picked up as writing an ident for a field value, because of punning.
  • The heuristic for whether you're intending to write a new record field picked up between fields (commas) but not at the start of the record body ({).

@zth zth requested a review from cristianoc May 29, 2024 11:35
@zth zth merged commit 4b555e5 into master May 29, 2024
6 checks passed
@zth zth deleted the fix-record-field-completion-in-existing-records branch May 29, 2024 16:14
jfrolich pushed a commit to jfrolich/rescript-vscode that referenced this pull request Sep 3, 2024
@zth @jfrolich
Fix expr record field completion in existing records (rescript-lang#997)
cebb9dd 
* fix case in expr record field completion where the record body context was not picked up

* fix case when cursor is at start of record body but in no field

* changelog

* dont use empty line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc