Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where pattern completion would not be triggered #999

Merged
merged 1 commit into from
May 31, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented May 31, 2024

Forgot to check for the cursor position when initiating pattern completion in a certain case.

@zth zth requested a review from cristianoc May 31, 2024 08:53
@zth
Copy link
Collaborator Author

zth commented May 31, 2024

Merging this before review as its a simple small fix and I need it to continue.

@zth zth merged commit d954df8 into master May 31, 2024
6 checks passed
@zth zth deleted the fix-pattern-completion-issue branch May 31, 2024 11:29
jfrolich pushed a commit to jfrolich/rescript-vscode that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant