-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit software and project improvements #558
Conversation
During testing, I noticed a weird bug. A (generated) project has a number of participating organizations: however, when I go to the edit page, no participating organizations are shown? Some other projects seem to show only part of the organizations in the edit page, and some show all (or at least the 1 organization registered). NOTE: according to Ewan these may be hosting organizations? |
It seems to work, I could not detect any major issues related to the PR. Here are some unrelated things: One thing I noticed is that the save button in the add project links does not support Ctrl+Enter to save. Another thing I noted that for very long texts in the markdown field, the user cannot see the character limit and has to scroll up to check whether they are still in the range. And here are some thoughts about auto saving in general: I am not sure whether the Markdown field should be saved automatically or whether the user should have the option to save manually. There is the potential to publish unfinished information here. Maybe we should also automatically set the status to unpublished when starting to edit the project description? To avoid that the project disappears entirely, there could also be a maintenance notification? But all this just seems like Save button with extra steps. I am not entirely sure how this could be solved. |
… queries, fix: project link enable submit on enter
…d with rsd item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Edit software and project improvements
This PR contains number of related changes for edit software and edit project page.
Closes #404
Closes #463
Closes #495
Closes #568
Changes proposed in this pull request:
How to test:
docker-compose down --volumes
to remove old versiondocker-compose build
to build all servicesdocker-compose up
to start solutionExample edit software info page (without save button)
Example contributors page with drag feature to change contributor position
Example of project info page without save button and with draggable project links
PR Checklist:
docker-compose.yml