Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit software and project improvements #558

Merged
merged 8 commits into from
Oct 10, 2022
Merged

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Oct 3, 2022

Edit software and project improvements

This PR contains number of related changes for edit software and edit project page.

Closes #404
Closes #463
Closes #495
Closes #568

Changes proposed in this pull request:

  • Edit project info section:
    •  The changes are save automatically. Save button is removed. View button is rename to View Page.
    • Project links order can by changed by dragging the item into desired position
  • Edit software - info section: The changes are save automatically. Save button is removed. View button is rename to View Page.
  • Edit software - contributors: the order of contributors can be changed by dragging the item into desired position

How to test:

  • docker-compose down --volumes to remove old version
  • docker-compose build to build all services
  • docker-compose up to start solution
  • Login as rsd_admin to be able to see all inputs on edit software and edit project pages
  • Create new software (you can use this guide)
    • manipulate all information in first section and view page. Confirm that all changes are saved properly
    • add contributors to software. Change the position of the contributor and confirm that change is reflected on the software page
  • Create new project
    • manipulate all information in the first section and view the page. Confirm that all changes are saved properly.
    • create project links. Change the order of the links and confirm that order is applied on the project page
  • Test adding mentions when searching by title. Use "Nearest Neighbours Improves Novelty Detection in Autoencoders" as example. Add this publication multiple times in the project impact and output. Adding should not produce error.

Example edit software info page (without save button)

image

Example contributors page with drag feature to change contributor position

image

Example of project info page without save button and with draggable project links

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic changed the title Edit software and project changes Edit software and project improvements Oct 4, 2022
@jmaassen
Copy link
Member

jmaassen commented Oct 4, 2022

During testing, I noticed a weird bug. A (generated) project has a number of participating organizations:

Screenshot 2022-10-04 at 11-43-24 project solid state interface 1912

however, when I go to the edit page, no participating organizations are shown?

Screenshot 2022-10-04 at 11-45-04 Edit project Research Software Directory

Some other projects seem to show only part of the organizations in the edit page, and some show all (or at least the 1 organization registered).

NOTE: according to Ewan these may be hosting organizations?

@cmeessen
Copy link
Contributor

cmeessen commented Oct 5, 2022

It seems to work, I could not detect any major issues related to the PR. Here are some unrelated things:

One thing I noticed is that the save button in the add project links does not support Ctrl+Enter to save.

Another thing I noted that for very long texts in the markdown field, the user cannot see the character limit and has to scroll up to check whether they are still in the range.

And here are some thoughts about auto saving in general:

I am not sure whether the Markdown field should be saved automatically or whether the user should have the option to save manually. There is the potential to publish unfinished information here. Maybe we should also automatically set the status to unpublished when starting to edit the project description? To avoid that the project disappears entirely, there could also be a maintenance notification? But all this just seems like Save button with extra steps. I am not entirely sure how this could be solved.

Copy link
Collaborator

@ewan-escience ewan-escience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dmijatovic dmijatovic merged commit ed8c958 into main Oct 10, 2022
@dmijatovic dmijatovic deleted the autosave-project-info branch October 12, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants