fix: more information in invitation email templates #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewan-escience
force-pushed
the
451-email-templates
branch
from
1c62a2c to
8916576
Compare
dmijatovic
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Nice work!
I do have two remarks.
I suggest to change the email subjects also into:
- Maintainer invite for RSD organisation {organisation_name}
- Maintainer invite for RSD project {project_title}
- Maintainer invite for RSD software {software_name}
The line breaks (\n) are not properly applied by my email client (Outlook online). But this problem was present from the beginning, so not sure if we can improve it.
dmijatovic
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information in invite email templates
Changes proposed in this pull request:
How to test:
docker-compose build frontend && docker-compose up --scale scrapers=0Closes #451
PR Checklist:
docker-compose.yml