Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove token endpoints from config
Changes proposed in this pull request:
*_TOKEN_URL
env variables and adapt the auth module so that the token URL is queried from the well known URL on every requestHELMHOLTZAAI_ALLOW_EXTERNAL_USERS=false
How to test:
*_TOKEN_URL
values from your.env
(seeenv.example
)docker-compose build auth && docker-compose up
HELMHOLTZAAI_ALLOW_EXTERNAL_USERS=true
HELMHOLTZAAI_ALLOW_EXTERNAL_USERS=false
You are not allowed to login
Discussion point
Maybe we should cache the token URL instead of querying it on every login. On my tests, ORCID was slow, taking 200 -- 900 ms. Helmholtz and SURF were below 100 ms.
Closes #589
PR Checklist:
docker-compose.yml