Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corda metrics should be obtainable for the reversible model as well #1

Closed
cdiener opened this issue Mar 31, 2016 · 1 comment
Closed
Milestone

Comments

@cdiener
Copy link
Member

cdiener commented Mar 31, 2016

Currently print called for a CORDA optimizer instance will give infos in the following form:

build status: reconstruction complete
Inc. reactions: 2238/5351
 - unclear: 657/2485
 - exclude: 95/863
 - low and medium: 922/1345
 - high: 564/658

However, this is based on the irreversible models and does not consider that the reversible reaction is added along with all included reactions. So it would be better to change those metrics to the reversible case or allow for an option to specify the behavior.

@cdiener
Copy link
Member Author

cdiener commented Jun 7, 2016

done in 392fcce.

@cdiener cdiener closed this as completed Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant