Add sourcelink to enable source debugging of the nuget package #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 3, 2020 10:32
I've tried hard with SonarQube, but its just too annoying to use
nuget restore wasn't working, which in turn meant that the dotnet test command wasn't working either (although msbuild still was interestingly) Using dotnet restore does work and fixes the problem Using dotnet to create the nuget package also required a few changes to the project
The code coverage still isn't working on appveyor, but is working locally, so hopefully using 2019, which is what I have on my computer, will work
Output version of opencover to check against local version Remove some esoteric type opencover parameters (this works locally) Make sure DebugSymbols are always included
It must return an exit code that stops the build, and actually it is displayed during the install step anyway.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
- Coverage 97.34% 96.92% -0.42%
==========================================
Files 41 41
Lines 1204 1204
Branches 0 54 +54
==========================================
- Hits 1172 1167 -5
Misses 32 32
- Partials 0 5 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.