Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow filing of Nil return for GSTR-1 #2906

Merged
merged 14 commits into from
Jan 11, 2025

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Dec 26, 2024

image

Show a checkbox to file NIL return if there is no data in books.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 59.86%. Comparing base (0df5519) to head (342b474).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...st_india/doctype/gst_return_log/generate_gstr_1.py 25.00% 6 Missing ⚠️
...mpliance/gst_india/api_classes/taxpayer_returns.py 25.00% 3 Missing ⚠️
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% 2 Missing ⚠️
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2906      +/-   ##
===========================================
- Coverage    59.90%   59.86%   -0.04%     
===========================================
  Files          122      122              
  Lines        12135    12142       +7     
===========================================
  Hits          7269     7269              
- Misses        4866     4873       +7     
Files with missing lines Coverage Δ
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 19.11% <0.00%> (+0.27%) ⬆️
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% <0.00%> (ø)
...mpliance/gst_india/api_classes/taxpayer_returns.py 51.11% <25.00%> (-3.66%) ⬇️
...st_india/doctype/gst_return_log/generate_gstr_1.py 14.53% <25.00%> (-0.09%) ⬇️

Impacted file tree graph

@ljain112 ljain112 self-assigned this Dec 26, 2024
@ljain112 ljain112 added the p1 label Dec 26, 2024
@vorasmit vorasmit marked this pull request as draft January 8, 2025 08:37
@vorasmit vorasmit marked this pull request as ready for review January 11, 2025 09:12
@mergify mergify bot merged commit 00ec2ca into resilient-tech:develop Jan 11, 2025
10 of 12 checks passed
india-compliance-bot added a commit that referenced this pull request Jan 15, 2025
# [15.15.0](v15.14.7...v15.15.0) (2025-01-15)

### Bug Fixes

* `ignore_permissions` when handeling missing gstr2a 2b transactions ([a2c2fda](a2c2fda))
* do not migrate old passwords if decryption fails ([f5f093c](f5f093c))
* enqueue only once for transactions created in bulk ([3faba43](3faba43))
* **gstr-1:** handle gov api error when downloading and make it optional for unfiled returns ([#2897](#2897)) ([744fedc](744fedc))
* ignore permissions for saving gstin doc ([133405c](133405c))
* only download sections with records ([924046e](924046e))
* primary action to reset on change of `is_nil` if already uploaded info ([225f681](225f681))
* round gst values before upload for accurate comparision with govt summary ([57252b8](57252b8))
* save nil filing information in gst return log ([c6c4352](c6c4352))
* selective download supported only for filled information, fixes related to updating description ([ea9feaa](ea9feaa))
* selectively download sections in GSTR-1 based on summary information ([abf6f02](abf6f02))
* set recon status for unlinked document ([7db22c8](7db22c8))
* suggest default return period correct when in first period ([1773cff](1773cff))
* support purchases from tax collector in purchae reco tool ([4ea05f6](4ea05f6))
* trim OTP values before sending ([7e33fa7](7e33fa7))
* unique name for events and doctype parameter alone is redundant ([#2903](#2903)) ([7d47599](7d47599))

### Features

* allow filing of Nil return for GSTR-1 ([#2906](#2906)) ([5a05376](5a05376)), closes [#2880](#2880)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow filing of Nil return for GSTR-1
3 participants