Fix: Use updated fork and remove exceptions for io.EOF error message #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicasomaiya
changed the title
ponteilla
approved these changes
Feb 20, 2023
jerny-stoiclane
pushed a commit
to jerny-stoiclane/terraform-provider-looker
that referenced
this pull request
Mar 1, 2023
jerny-stoiclane
pushed a commit
to jerny-stoiclane/terraform-provider-looker
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates dependencies to point to the most up-to-date
resolutionlifebranch on our forkresolutionlife/looker-sdk-codegen, which includes a fix to this bug: looker-open-source/sdk-codegen#1074 (specifically this fix!)With this fix in, we no longer need to make exceptions when the API returns
io.EOFerror messages, so these are removed in this PR too.