Fix player header icon dark mode colors #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonv3
reviewed
Jun 24, 2022
simonv3
reviewed
Jun 24, 2022
Co-authored-by: Psi <simonv3@users.noreply.github.com>
Co-authored-by: Psi <simonv3@users.noreply.github.com>
simonv3
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the
Headericon logo and audioPlayercomponent's dark mode colors. I've also added a subtle drop shadow to theHeaderandPlayerfor some more separation and slight elevation.This closes #76.
This closes #89.
Eventually we'll want to implement a toggle for #76 and do this a better way, but this will tide users over for now, and I've created an issue for this: #163.